Fix extra padding in the bottom of the page for IE11 and Firefox#1949
Merged
corinagum merged 5 commits intomicrosoft:masterfrom May 1, 2019
Merged
Fix extra padding in the bottom of the page for IE11 and Firefox#1949corinagum merged 5 commits intomicrosoft:masterfrom
corinagum merged 5 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
corinagum
approved these changes
May 1, 2019
Member
|
35.8% coverage increase? What?! |
Contributor
|
!!! 58% total coverage is where we've been sitting for a while... I don't know where that 35.8% is coming from. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra
<div>above<svg>is causing the issue.Updated all snapshots because the SVG is 0.5 pixels smaller. No other visible differences otherwise. Similar to the one below.