Skip to content

Remove a layer of URLSearchParams#1938

Merged
corinagum merged 3 commits intomicrosoft:masterfrom
compulim:fix-embed-edge
Apr 30, 2019
Merged

Remove a layer of URLSearchParams#1938
corinagum merged 3 commits intomicrosoft:masterfrom
compulim:fix-embed-edge

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Apr 29, 2019

Edge fails if new URLSearchParams(new URLSearchParams()), but Chrome and Firefox passed.

We should remove the extra new URLSearchParams() here.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 29, 2019

Coverage Status

Coverage decreased (-0.04%) to 58.114% when pulling b4b4431 on compulim:fix-embed-edge into 0001b8e on Microsoft:master.

@compulim
Copy link
Copy Markdown
Contributor Author

@corinagum I tested this PR and it fixed the problem.

@corinagum corinagum merged commit 8ef6e55 into microsoft:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants