Clean up test from #1915#1933
Merged
corinagum merged 2 commits intomicrosoft:masterfrom Apr 26, 2019
Merged
Conversation
corinagum
approved these changes
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up test from #1915:
/__tests__/setup/web/index.htmlbasic.jsis for really basic stuff, like, if Web Chat can be loaded or not (i.e. setup test)basic.jsacts as the first gate to check if everything is brokenbasic.jsneed to be done latercreateStyleSetoption tomain()styleSetinstead of the newcreateStyleSetfunctionstyleSetis designed to be serializable with flat hierarchycreateStyleSethere because we want the new style set to based on Web Chat's default, i.e. need to callwindow.WebChat.createStyleSet(styleOptions), then customize the resultObject.assignis used instead