Skip to content

Fix 1789 - switch focus back to sendbox after send#1915

Merged
corinagum merged 3 commits intomicrosoft:masterfrom
corinagum:1789-focus
Apr 22, 2019
Merged

Fix 1789 - switch focus back to sendbox after send#1915
corinagum merged 3 commits intomicrosoft:masterfrom
corinagum:1789-focus

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

Fix #1789

  • This UX fix will return focus back to the Send Box after the Send Button has been pressed. This particularly helps the user experience on iOS Safari.
  • How I tested it: If styleInputBackground is true for rendering Web Chat, update the page styles to turn inputs to yellow background if focused. This tests focus after Send Button has been clicked. This should only apply to SendBox UI test.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 21, 2019

Coverage Status

Coverage increased (+0.05%) to 54.116% when pulling 38df91f on corinagum:1789-focus into 09536a5 on Microsoft:master.

Comment thread CHANGELOG.md Outdated
- Fix [#1827](https://github.com/Microsoft/BotFramework-WebChat/issues/1827). Remove renderer for unknown activities, by [@corinagum](https://github.com/corinagum) in PR [#1873](https://github.com/Microsoft/BotFramework-WebChat/pull/1873)
- Fix [#1586](https://github.com/Microsoft/BotFramework-WebChat/issues/1586). Fix theming of suggested actions buttons, by [@corinagum](https://github.com/corinagum) in PR [#1883](https://github.com/Microsoft/BotFramework-WebChat/pull/1883)
- Fix [#1837](https://github.com/Microsoft/BotFramework-WebChat/issues/1837), [#1643](https://github.com/Microsoft/BotFramework-WebChat/issues/1643). Fix style conflicts with bootstrap and bump `memoize-one`, by [@corinagum](https://github.com/corinagum) in PR [#1884](https://github.com/Microsoft/BotFramework-WebChat/pull/1884)
- Fix [#1789](https://github.com/Microsoft/BotFramework-WebChat/issues/1789). Patched something, by [@corinagum](https://github.com/corinagum) in PR [#1915](https://github.com/Microsoft/BotFramework-WebChat/pull/1915)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change log entry doesn't seem very useful

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks Chris.

@corinagum corinagum merged commit 8ec98f8 into microsoft:master Apr 22, 2019
corinagum pushed a commit that referenced this pull request Apr 26, 2019
* Clean up test

* Update entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Focus back to send box after tapping on the send button

3 participants