New embed page#1910
Merged
compulim merged 69 commits intomicrosoft:masterfrom Apr 24, 2019
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
justinwilaby
suggested changes
Apr 23, 2019
justinwilaby
left a comment
justinwilaby
left a comment
There was a problem hiding this comment.
Some minor considerations. Overall it looks good.
corinagum
reviewed
Apr 23, 2019
corinagum
reviewed
Apr 23, 2019
corinagum
reviewed
Apr 23, 2019
corinagum
reviewed
Apr 23, 2019
corinagum
reviewed
Apr 23, 2019
justinwilaby
approved these changes
Apr 23, 2019
Contributor
|
Failing test should be resolved with a pull from |
Co-Authored-By: compulim <[email protected]>
Co-Authored-By: compulim <[email protected]>
Co-Authored-By: compulim <[email protected]>
Co-Authored-By: compulim <[email protected]>
Co-Authored-By: compulim <[email protected]>
Co-Authored-By: compulim <[email protected]>
Co-Authored-By: compulim <[email protected]>
Co-Authored-By: compulim <[email protected]>
Co-Authored-By: compulim <[email protected]>
compulim
force-pushed
the
feat-embed-page
branch
from
9164398 to
c05d758
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are going to point temporarily to cdnbotframeworkdev.blob.core.windows.net in this PR. Once we got the actual URL, will replace them. This is for CDN segregation work.
This page will be redirected thru existing endpoint, https://webchat.botframework.com/embed/.
The output will be two files:
index.html, a single HTML file containing the page and inlined JavaScript codeservicingplan.jsonIt will fetch bot configuration from https://webchat.botframework.com/v4/embed/config/, and emit telemetry to /v4/embed/telemetry/.
When we need to load the legacy v1/v3 pages, we will IFRAME back into the existing endpoint, with special URL query parameters to prevent looping back to this page.
We will have server-side changes to support this page.