Skip to content

Wrapping input text#1889

Merged
cwhitten merged 8 commits intomicrosoft:masterfrom
tdurnford:17
Apr 12, 2019
Merged

Wrapping input text#1889
cwhitten merged 8 commits intomicrosoft:masterfrom
tdurnford:17

Conversation

@tdurnford
Copy link
Copy Markdown
Contributor

@tdurnford tdurnford commented Apr 10, 2019 •
edited
Loading

Fixes #17
Fixes #124

Added textarea input as a style option per issues #17 and #124.

const styleSet = createStyleSet({
    sendBoxTextWrap: true
});

input-js-textarea-input-multiple-lines-1-snap

corinagum
corinagum reviewed Apr 10, 2019
View reviewed changes
Comment thread packages/component/src/Styles/StyleSet/SendBoxTextarea.js
Comment thread CHANGELOG.md Outdated
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 10, 2019 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 54.065% when pulling 302fa76 on tdurnford:17 into eaa3f61 on Microsoft:master.

@corinagum
Copy link
Copy Markdown
Contributor

corinagum commented Apr 10, 2019 •
edited
Loading

You can take a look at failing tests here: https://webchattest.blob.core.windows.net/travis-result/2019/04/10/s64hm/index.html
https://travis-ci.org/Microsoft/BotFramework-WebChat/builds/518536828?utm_source=github_status&utm_medium=notification

@tdurnford tdurnford changed the title [Draft] Wrapping input text Wrapping input text Apr 11, 2019
justinwilaby
justinwilaby approved these changes Apr 11, 2019
View reviewed changes
Copy link
Copy Markdown

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwhitten
Copy link
Copy Markdown
Member

cwhitten commented Apr 12, 2019

thanks for the contribution @tdurnford ! this is good stuff

@cwhitten cwhitten merged commit 79c39e5 into microsoft:master Apr 12, 2019
@EdwinOtten
Copy link
Copy Markdown

EdwinOtten commented Apr 18, 2019

Thanks @tdurnford! Also nice that it is an optional feature 👍

@babupca
Copy link
Copy Markdown

babupca commented Mar 31, 2022

@tdurnford , Is sendBoxTextWrap fix released, We are using the webchat, where require the inputted text to be wrapped, which has not happened. Kindly suggest to us which version of WebChat do need to use to get this issue fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

2 more reviewers

@corinagum corinagum corinagum left review comments

@justinwilaby justinwilaby justinwilaby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support multi-line text box and use shift-enter for line break Wrapping input text

7 participants

@tdurnford @coveralls @corinagum @cwhitten @EdwinOtten @babupca @justinwilaby