Skip to content

Fix CSS collisions with Bootstrap and bump memoize-one#1884

Merged
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:1837
Apr 9, 2019
Merged

Fix CSS collisions with Bootstrap and bump memoize-one#1884
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:1837

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Apr 9, 2019

Fixes #1837
Fixes #1643

  • End collision of external styles like Bootstrap by changing the .row class in Web Chat to .webchat__row
  • Bump memoize-one

@compulim
Copy link
Copy Markdown
Contributor

compulim commented Apr 9, 2019

I am thinking to convert it to BEM naming convention, i.e. webchat__row.

But if @cwhitten is okay with the current one, webchat-row, then let's hit this first and then go to BEM later.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 9, 2019

Coverage Status

Coverage decreased (-0.03%) to 52.723% when pulling b91d3df on corinagum:1837 into e561bc4 on Microsoft:master.

@corinagum corinagum merged commit c2f9021 into microsoft:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants