Remove renderer for unknown activities#1873
Merged
corinagum merged 2 commits intomicrosoft:masterfrom Apr 4, 2019
Merged
Conversation
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
justinwilaby and
tonyanziano
as code owners
Member
|
it looks like the build failed on travis. |
Contributor
Author
|
:( On it |
tonyanziano
approved these changes
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1827
This fix removes the render for unknown activities to Web Chat (all activities excluding Message, Event, and Typing). For users wanting to create their own rendering component based off of an activity, take a look at incoming activities and creating custom components sample.
The above screencap is what is rendered when the following activity is sent by the bot: