1523 Offline UI - connecting for the first time#1866
Merged
corinagum merged 10 commits intomicrosoft:masterfrom Apr 4, 2019
Merged
1523 Offline UI - connecting for the first time#1866corinagum merged 10 commits intomicrosoft:masterfrom
corinagum merged 10 commits intomicrosoft:masterfrom
Conversation
added 8 commits
March 28, 2019 15:09
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
justinwilaby and
tonyanziano
as code owners
tonyanziano
reviewed
Apr 3, 2019
tonyanziano
reviewed
Apr 3, 2019
tonyanziano
reviewed
Apr 3, 2019
tonyanziano
reviewed
Apr 3, 2019
tonyanziano
reviewed
Apr 3, 2019
tonyanziano
approved these changes
Apr 3, 2019
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
Minor style nitpicks. Looks good!
|
I can see the connecting loader appears briefly. I have a scenario where I use a back channel activity to post data to user as a welcome message. Sometimes, the message might take a while to appear in the conversation window. Is there a way to wait for the back channel post back welcome message and show the connecting loader until then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1524
Fix #1856
This now brings 'Connecting...' text to Web Chat when connecting for the first time.
Scenario 1: User connects to Web Chat for the first time, and 'Connecting...' disappears after connection via DirectLine is made.
Scenario 2: User connects to Web Chat for the first time, and 'Connecting...' shows until it changes to 'Taking longer than usual to connect'
(difference in quality is due to making the gifs on different websites)
Notes