Skip to content

Add word-wrap to messageActivity#1832

Merged
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:corinagum/1774
Mar 21, 2019
Merged

Add word-wrap to messageActivity#1832
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:corinagum/1774

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Mar 21, 2019

Fix #1774

Previously, long urls or long (single) words would be clipped. Now, Web Chat will by default break on word. This does mean long URLs break arbitrarily.

image
Note that semi-long words will wrap normally. See 'monospace' below:
image

Web Chat users may use defaultStyleSetOptions to change this default value. Available options are normal, break-all, break-word, and keep-all.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 21, 2019

Coverage Status

Coverage remained the same at 51.961% when pulling a051594 on corinagum:corinagum/1774 into 1512fe6 on Microsoft:master.

Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also test one other mode (keep-all)? As a control experiment that this option actually works.

Comment thread __tests__/basic.js Outdated
@corinagum corinagum merged commit 1fc6ab4 into microsoft:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants