Adding sample for hosting WebChat in an Angular application#1813
Merged
Adding sample for hosting WebChat in an Angular application#1813
Conversation
omarsourour
requested review from
a-b-r-o-w-n,
cwhitten,
justinwilaby and
tonyanziano
as code owners
Contributor
|
Looks good to me! Can you add an entry to |
omarsourour
force-pushed
the
omsour/ng_webchat_sample_0.1
branch
from
e402bc9 to
36cced6
Compare
Contributor
Author
|
@corinagum Done, added entry in ChangeLog. Please give it a look :) |
Contributor
|
Oops! Sorry Omar, a couple more things
Otherwise, looks good and I will merge after your final commit. Sorry about that! |
Contributor
Author
|
@corinagum Done :) .. Please take a look Also, may I ask/suggest why not have the root README.md link to the samples/README.md? :) |
Contributor
|
@omarsourour oh is there a way to automatically update one and it will update the other? If so please let me know how! Thank you! |
corinagum
approved these changes
Mar 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1423