Updated Danish localization#1810
Merged
corinagum merged 5 commits intomicrosoft:masterfrom Mar 19, 2019
Merged
Conversation
Simonlfr
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
|
|
Contributor
|
Please add an entry to CHANGELOG.md. Thanks for your contribution! |
iMicknl
reviewed
Mar 14, 2019
| 'Speak': 'Tal', | ||
| 'Upload file': 'Upload fil', | ||
| 'Type your message': 'Skriv din besked' | ||
| // 'X minutes ago': |
Contributor
There was a problem hiding this comment.
Should be changed to: 'X minutes ago': xMinutesAgo.
Edit: Nevermind, see that this string is already defined at the top. This commented out string just makes it a bit unclear :).
Contributor
There was a problem hiding this comment.
please delete this line! Thanks for the catch
corinagum
reviewed
Mar 14, 2019
| 'Retry': '{retry}', // Please alter this value if 'Retry' at the beginning of a sentence is written differently than at the end of a sentence. | ||
| 'Sending': 'sender', | ||
| // 'Starting…': '', | ||
| 'Retry': '{prøv igen}', // Please alter this value if 'Retry' at the beginning of a sentence is written differently than at the end of a sentence. |
Contributor
There was a problem hiding this comment.
Is this supposed to be Prøv igen? If so, please update and remove the { and }
Contributor
Author
There was a problem hiding this comment.
I deleted the { and }.
Deleted redundant line 'X minutes ago'.
Deleted { and } on retry line.
corinagum
reviewed
Mar 18, 2019
corinagum
approved these changes
Mar 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.