Skip to content

Update Spanish localization#1757

Merged
corinagum merged 4 commits intomicrosoft:masterfrom
CKGrafico:master
Mar 6, 2019
Merged

Update Spanish localization#1757
corinagum merged 4 commits intomicrosoft:masterfrom
CKGrafico:master

Conversation

@CKGrafico
Copy link
Copy Markdown
Contributor

Not sure if you forget, but there is no Spanish translation for xminutes ago.
I copy pasted english version and translated

@corinagum
Copy link
Copy Markdown
Contributor

Hi @CKGrafico, thanks for the submission! Could you do a few things?

  1. Please add the FAILED_CONNECTION_NOTIFICATION and SLOW_CONNECTION_NOTIFICATION strings on es-ES.js
  2. Please add your change to CHANGELOG.md
  3. Please add your name to the LOCALIZATION.md

@CKGrafico
Copy link
Copy Markdown
Contributor Author

@corinagum done, feel free to give more feedback about both readmes :)

@CKGrafico
Copy link
Copy Markdown
Contributor Author

News about this?

@corinagum
Copy link
Copy Markdown
Contributor

@CKGrafico Looks good! Sorry, I was on vacation. :)

@corinagum corinagum merged commit d47947f into microsoft:master Mar 6, 2019
@CKGrafico
Copy link
Copy Markdown
Contributor Author

CKGrafico commented Mar 6, 2019

Thanks for your time @corinagum :) I've updated to "botframework-webchat": "^4.3.0", but botframework-webchat-component is still with the same version, any idea how to update? (in node_modules I have [email protected]

@CKGrafico
Copy link
Copy Markdown
Contributor Author

Updates?

@corinagum
Copy link
Copy Markdown
Contributor

These changes will not be available until the 4.4 release mid-April unless you are using the master bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants