Skip to content

#1625: Update root README.md and SAMPLES.md#1752

Merged
corinagum merged 3 commits intomicrosoft:masterfrom
corinagum:corinagum/1625
Feb 25, 2019
Merged

#1625: Update root README.md and SAMPLES.md#1752
corinagum merged 3 commits intomicrosoft:masterfrom
corinagum:corinagum/1625

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Feb 22, 2019

Fix #1625

  • Update default user information - Web Chat will now generate a random id.
  • Add rootHeight and rootWidth styling examples in SAMPLES.md

new screen caps:

Screenshot of Web Chat

Web Chat with rootHeight and rootWidth set

Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merge, could you update the image without the black border. I would suggest using some photo editing tools to crop accurately.

If you don't have any tools around, please commit the PNG image in the source branch so we can work on it later. The image uploaded by CTRL + V is not editable.

Also, the resolution on the image seems wrong, it looks pretty blurry in 100%.

@corinagum corinagum merged commit b95462b into microsoft:master Feb 25, 2019
@corinagum
Copy link
Copy Markdown
Contributor Author

Merged this in since Travis build said it passed but GH didn't update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants