fixed locale pt-br not being used and added extra suport for pt-br#1745
Merged
corinagum merged 4 commits intomicrosoft:masterfrom Feb 20, 2019
Merged
fixed locale pt-br not being used and added extra suport for pt-br#1745corinagum merged 4 commits intomicrosoft:masterfrom
corinagum merged 4 commits intomicrosoft:masterfrom
Conversation
pedropacheco92
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
|
|
|
Nice Work!! |
corinagum
reviewed
Feb 20, 2019
| return 'pl-PL'; | ||
| } else if (language.startsWith('pt')) { | ||
| if (language === 'pt-BR') { | ||
| if (language === 'pt-br') { |
Contributor
There was a problem hiding this comment.
could you explain why this is necessary?
Contributor
Author
There was a problem hiding this comment.
in the first line of this function, the language is setted to lower case, and this condidion was never true.
Contributor
There was a problem hiding this comment.
Ah I understand now, thank you!
| } | ||
|
|
||
| export default { | ||
| // FAILED_CONNECTION_NOTIFICATION: '', |
Contributor
There was a problem hiding this comment.
Are you able to fill the commented-out lines to finish up this localization file? :)
corinagum
suggested changes
Feb 20, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
I should have said this earlier, my apologies.
- Please add your updates to the
CHANGELOG.md - Please add your name to the
LOCALIZATION.md
Thank you for your contribution!
Contributor
Author
|
Fixed conflict |
corinagum
approved these changes
Feb 20, 2019
Contributor
|
Will merge in once tests pass. Thanks again! |
Contributor
|
These changes will be in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.