Skip to content

De support#1740

Merged
corinagum merged 4 commits intomicrosoft:masterfrom
matmuenzel:de-support
Feb 19, 2019
Merged

De support#1740
corinagum merged 4 commits intomicrosoft:masterfrom
matmuenzel:de-support

Conversation

@matmuenzel
Copy link
Copy Markdown
Contributor

extend german language support

thank you

@msftclas
Copy link
Copy Markdown

msftclas commented Feb 18, 2019

CLA assistant check
All CLA requirements met.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 18, 2019

Coverage Status

Coverage decreased (-0.9%) to 55.152% when pulling 14eacc6 on matmuenzel:de-support into 25b2c47 on Microsoft:master.

Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your changes to CHANGELOG.md. Thank you for the submission!

Comment thread packages/component/src/Localization/de-DE.js Outdated
@corinagum
Copy link
Copy Markdown
Contributor

Added my approval, but tests are still failing. I'll investigate what's going on today. :)

@corinagum corinagum merged commit d7affe2 into microsoft:master Feb 19, 2019
@corinagum
Copy link
Copy Markdown
Contributor

(failing test had to do with an accidental regression in Mock Bot, which has been addressed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants