Hide suggested actions not destinated to the user#1706
Merged
cwhitten merged 6 commits intomicrosoft:masterfrom Feb 9, 2019
Merged
Hide suggested actions not destinated to the user#1706cwhitten merged 6 commits intomicrosoft:masterfrom
cwhitten merged 6 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
corinagum
suggested changes
Feb 7, 2019
tonyanziano
approved these changes
Feb 7, 2019
Co-Authored-By: compulim <[email protected]>
justinwilaby
reviewed
Feb 8, 2019
justinwilaby
approved these changes
Feb 8, 2019
justinwilaby
left a comment
justinwilaby
left a comment
There was a problem hiding this comment.
LGTM assuming the build failure is addressed.
corinagum
approved these changes
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Suggested actions (spec here) can specify
tofield to show the suggested actions only for a set of users.Today, we did not filter suggested actions based on the
tofield.This fix will not show suggested actions with a
tofield targeting another user. For backward compatibility reason, if thetofield is empty or not defined, we will continue to show suggested actions.Changelog
Fixed