Added customizable height and width style options to root.#1702
Merged
tonyanziano merged 1 commit intomasterfrom Feb 6, 2019
Merged
Added customizable height and width style options to root.#1702tonyanziano merged 1 commit intomasterfrom
tonyanziano merged 1 commit intomasterfrom
Conversation
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
justinwilaby
as code owners
Contributor
|
PSA to anyone looking to alter this feature in their implementation of Web Chat: please take a look at our branding sample on how to change default styles. |
Contributor
Author
|
I'll add a changelog entry and rebase upon approval. |
corinagum
approved these changes
Feb 6, 2019
a-b-r-o-w-n
approved these changes
Feb 6, 2019
a-b-r-o-w-n
requested changes
Feb 6, 2019
Contributor
a-b-r-o-w-n
left a comment
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
Forgot to update the changelog!
tonyanziano
force-pushed
the
toanzian/100%-webchat
branch
from
a8158e5 to
662ba3c
Compare
a-b-r-o-w-n
approved these changes
Feb 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1267
===
This adds customizable
rootHeight&rootWidthstyleset options to the root style set.Images of working sample: (background element is pink)
50% height / width
100% height / 75% width