You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds a new component to the transcript that will notify the user when connectivity to the bot is taking longer than usual or has failed.
For slow connection, Web Chat will time 15 seconds before displaying the below warning:
A failed connection will be triggered when credentials are incorrect.
Update Italian localization, courtesy of andreo
@compulim, can you go through the Chinese localization files and add to FAILED_CONNECTION_NOTIFICATION and SLOW_CONNECTION_NOTIFICATION? I'll update my PR with your changes.
@mewa1024@DesignPolice given that WebChat isn't a public facing name given to the Chat window, should we make the copy more generic? Take BuzzFeed's recent Zo bot. It would be odd to see "WebChat" in error/warning copy here. But I could imagine more generic copy that doesn't call out WebChat specifically.
@cwhitten@mewa1024@corinagum - That is true Chris, I forget that we need to be more generic with so many different uses of our product. That seems fine to me Mewa.
Update: I've updated the copy and fixed the build, but I'm having trouble getting tests to run locally so that I can update the png's for the ConnectivityStatus tests. Will check back in a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
justinwilaby and
tonyanziano
as code owners
tonyanziano
left a comment
Resolves #1521
This adds a new component to the transcript that will notify the user when connectivity to the bot is taking longer than usual or has failed.
For slow connection, Web Chat will time 15 seconds before displaying the below warning:
A failed connection will be triggered when credentials are incorrect.
FAILED_CONNECTION_NOTIFICATIONandSLOW_CONNECTION_NOTIFICATION? I'll update my PR with your changes.