add chat send history sample#1678
Merged
a-b-r-o-w-n merged 4 commits intomicrosoft:masterfrom Feb 4, 2019
a-b-r-o-w-n:chat-history-sample
Merged
add chat send history sample#1678a-b-r-o-w-n merged 4 commits intomicrosoft:masterfrom a-b-r-o-w-n:chat-history-sample
a-b-r-o-w-n merged 4 commits intomicrosoft:masterfrom
a-b-r-o-w-n:chat-history-sample
Conversation
a-b-r-o-w-n
requested review from
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
Pull Request Test Coverage Report for Build 911
💛 - Coveralls |
Member
|
I'm unclear why this isn't provided by the component out of the box! |
Contributor
Author
|
@cwhitten one thing I can think of in opposition to adding this to the bundle is concerns over security / managing the session state. Would it be by user / conversation / bot / something else? IMO this is better suited as a custom add on that suits the customer's need. Also, while this feature is helpful for testing, I am not convinced that it is useful for the majority of bot interactions. |
cwhitten
approved these changes
Feb 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1091
Added
samples: Added chat send history sample, by @a-b-r-o-w-n, in PR #1678