Skip to content

Extend style options to support basic adaptive cards style#1670

Merged
a-b-r-o-w-n merged 9 commits intomicrosoft:masterfrom
a-b-r-o-w-n:adaptive-card-styling
Feb 4, 2019
Merged

Extend style options to support basic adaptive cards style#1670
a-b-r-o-w-n merged 9 commits intomicrosoft:masterfrom
a-b-r-o-w-n:adaptive-card-styling

Conversation

@a-b-r-o-w-n
Copy link
Copy Markdown
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Jan 30, 2019 •
edited
Loading

Currently only passes font family and font colors through

Added

  • component: Allow font family and adaptive cards text color to be set via styleOptions, by @a-b-r-o-w-n, in PR #1670

a-b-r-o-w-n
a-b-r-o-w-n commented Jan 31, 2019
View reviewed changes
Comment thread packages/component/src/Styles/adaptiveCardHostConfig.js
subtle: subtle
}
}
},
Copy link
Copy Markdown
Contributor Author

@a-b-r-o-w-n a-b-r-o-w-n Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@compulim I'd like your opinion on this.

I made these changes based on the themes in Emulator. I think that allowing users to override the host config handles the extreme case of needing to fully customize the adaptive cards config. This change only passes a few things from the style options through.

Let me know what you think. We could extend this and add more options to styleOptions, but I thought that would not be necessary since the override already exists.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 31, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 915

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 52.466%
Files with Coverage Reduction New Missed Lines %
packages/bundle/src/createDirectLine.js 3 20.0%
packages/component/src/Utils/TimeAgo.js 3 70.59%
packages/component/src/Utils/Timer.js 6 33.33%
Totals Coverage Status
Change from base Build 889: -0.08%
Covered Lines: 878
Relevant Lines: 1522
💛 - Coveralls

@a-b-r-o-w-n
Copy link
Copy Markdown
Contributor Author

a-b-r-o-w-n commented Jan 31, 2019

@compulim or @corinagum How should I proceed with the failing image snapshots?

@corinagum
Copy link
Copy Markdown
Contributor

corinagum commented Jan 31, 2019

@a-b-r-o-w-n were there slight color changes? that's the only difference I can see in the snapshots.
https://webchattest.blob.core.windows.net/travis-result/2019/01/31/gy262/index.html
If that's the case, you can delete the failing images and run the tests locally again to push up the new png's. :)

@a-b-r-o-w-n
Copy link
Copy Markdown
Contributor Author

a-b-r-o-w-n commented Jan 31, 2019

@corinagum ah. yes. probably because of this: https://github.com/Microsoft/BotFramework-WebChat/pull/1670/files#diff-27cc33be5272a601ab9ad5a925024b12R20. I'll revert that and see if it passes.

compulim
compulim reviewed Jan 31, 2019
View reviewed changes
Comment thread packages/component/src/Styles/adaptiveCardHostConfig.js Outdated
@compulim compulim mentioned this pull request Jan 31, 2019
Closed
corinagum
corinagum approved these changes Feb 1, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're waiting for @compulim's input. Just wanted to throw in that this looks good to me! We should definitely get this in before my ConnectivityStatus PR so that I can emulate these changes in the components I made.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 405af69 into microsoft:master Feb 4, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the adaptive-card-styling branch February 4, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim left review comments

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

+1 more reviewer

@corinagum corinagum corinagum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a-b-r-o-w-n @coveralls @corinagum @compulim