Conversation
a-b-r-o-w-n
requested review from
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
corinagum
suggested changes
Jan 22, 2019
Contributor
|
Do we want to include a11y in this PR, as well as selecting an activity programmatically? If not, we shouldn't close #1117 or file a new bug. :) |
a-b-r-o-w-n
force-pushed
the
select-activity
branch
from
127e44a to
f71a61c
Compare
Contributor
Author
I'm not sure the programatic selection makes sense (there is another example showing integration with the redux store) which can be expanded to add the programatic selection. I am working on a11y now. I'll push up a new commit shortly. |
corinagum
approved these changes
Jan 23, 2019
Contributor
|
Created #1632 for discussion / tracking for a sample of programmatically selectable activities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1117
TODO: