Rename sendTyping to sendTypingIndicator and add deprecation notes#1584
Merged
compulim merged 11 commits intomicrosoft:masterfrom Jan 27, 2019
Merged
Rename sendTyping to sendTypingIndicator and add deprecation notes#1584compulim merged 11 commits intomicrosoft:masterfrom
sendTyping to sendTypingIndicator and add deprecation notes#1584compulim merged 11 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
Pull Request Test Coverage Report for Build 861
💛 - Coveralls |
compulim
force-pushed
the
deprecate-send-typing
branch
from
cd829f5 to
399b0de
Compare
compulim
changed the title
sendTyping to sendTypingIndicator and add deprecation notessendTyping to sendTypingIndicator and add deprecation notes
corinagum
reviewed
Jan 23, 2019
Member
|
@compulim let's address the coverage and get this merged |
compulim
force-pushed
the
deprecate-send-typing
branch
from
399b0de to
52e8c14
Compare
Co-Authored-By: compulim <[email protected]>
compulim
force-pushed
the
deprecate-send-typing
branch
from
7051a54 to
fc20bb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
sendTypingIndicatoris a better name for sending user's typing activity.We are modifying a few areas in our code: actions, props, reducers, sagas, selectors. And adding a deprecation notes to them.
We will complete the deprecation and remove the code on 2020 January.