Add messageBack support to suggested actions#1581
Merged
corinagum merged 8 commits intomicrosoft:masterfrom Jan 16, 2019
Merged
Add messageBack support to suggested actions#1581corinagum merged 8 commits intomicrosoft:masterfrom
corinagum merged 8 commits intomicrosoft:masterfrom
Conversation
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
justinwilaby and
tonyanziano
as code owners
Pull Request Test Coverage Report for Build 760
💛 - Coveralls |
corinagum
changed the title
corinagum
force-pushed
the
corinagum/messageBack
branch
from
acbd369 to
4d0f32f
Compare
compulim
requested changes
Jan 14, 2019
Contributor
compulim
left a comment
compulim
left a comment
There was a problem hiding this comment.
Please rebase master. There are lot so changes around saga.
a-b-r-o-w-n
reviewed
Jan 14, 2019
Contributor
Author
|
@compulim @a-b-r-o-w-n I have pushed PR changes up. My tests pass locally, and I'm not sure why it's saying coverage went down since I added tests. I will check with @compulim in person to see if he has advice. |
Contributor
Author
|
@compulim and @a-b-r-o-w-n please ignore above comment - after a slight delay the travis build updated to say there was a 3% increase, and that tests are passing. |
compulim
approved these changes
Jan 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1402
messageBacksupportmessageBacksuggested actionssuggested-actionscommand have been addedimageandtitle(what the button displays) are individually optional, but one or the other must be defineddisplayTextrepresents the optional response from the user when a suggested action is selectedtextandvaluemay be empty, in which case an empty suggested action is sent to the botMock Bot with added suggested-actions
messageBackas JSON with display text.