Fix error with string interpolation#1509
Merged
compulim merged 8 commits intomicrosoft:masterfrom Dec 21, 2018
Merged
Conversation
compulim
requested changes
Dec 18, 2018
Contributor
compulim
left a comment
compulim
left a comment
There was a problem hiding this comment.
Could you update CHANGELOG.md to include this PR?
compulim
requested changes
Dec 18, 2018
Not sure if it's right, since I don't have a browser without Intl support
Pull Request Test Coverage Report for Build 647
💛 - Coveralls |
compulim
approved these changes
Dec 21, 2018
Contributor
|
👍 (Waiting for Travis CI to complete and will merge) Thanks. I didn't realize we didn't handle peaceful fallback of |
Contributor
|
It's in, should be start popping up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.