Skip to content

Accessibility & Icon fixes#1506

Merged
corinagum merged 11 commits intomicrosoft:masterfrom
corinagum:corinagum/1425
Dec 18, 2018
Merged

Accessibility & Icon fixes#1506
corinagum merged 11 commits intomicrosoft:masterfrom
corinagum:corinagum/1425

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

Fix #1264,
Fix #1308,
Fix #1318,
Fix #1334,
Fix #1425

  • Accessibility/Narrator fixes
  • Fix host-with-react sample fix.
  • Update Web Chat icons (Microphone, Send, Attachment, & Download)

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 18, 2018

Pull Request Test Coverage Report for Build 626

  • 5 of 8 (62.5%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 44.979%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/Attachment/Assets/DownloadIcon.js 0 1 0.0%
packages/component/src/SendBox/Assets/MicrophoneIcon.js 1 2 50.0%
packages/component/src/Utils/AdaptiveCardBuilder.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/component/src/Utils/AdaptiveCardBuilder.ts 1 0.0%
Totals Coverage Status
Change from base Build 622: 0.05%
Covered Lines: 726
Relevant Lines: 1441

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@corinagum corinagum merged commit 2a2b3b9 into microsoft:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants