Skip to content

Color contrast ratio fixes & downloadIcon narrator accessibility#1494

Merged
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:corinagum/contrast-ratios
Dec 13, 2018
Merged

Color contrast ratio fixes & downloadIcon narrator accessibility#1494
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:corinagum/contrast-ratios

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Dec 13, 2018

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 13, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 609

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 84 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-6.3%) to 38.316%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/Attachment/DownloadAttachment.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/core/src/actions/incomingActivity.js 1 50.0%
packages/core/src/sagas/effects/observeOnce.js 1 50.0%
packages/component/src/Attachment/ImageAttachment.js 1 0.0%
packages/component/src/Middleware/Activity/createCoreMiddleware.js 1 62.5%
packages/component/src/Utils/textFormatToContentType.js 1 42.86%
packages/component/src/Attachment/DownloadAttachment.js 1 0.0%
packages/component/src/Localization/Localize.js 1 34.94%
packages/component/src/Attachment/ImageContent.js 2 0.0%
packages/bundle/src/renderMarkdown.js 2 12.5%
packages/component/src/Activity/Timestamp.js 2 0.0%
Totals Coverage Status
Change from base Build 598: -6.3%
Covered Lines: 632
Relevant Lines: 1427
💛 - Coveralls

@a-b-r-o-w-n a-b-r-o-w-n self-requested a review December 13, 2018 18:46
cwhitten
cwhitten requested changes Dec 13, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion

Comment thread packages/component/src/Attachment/DownloadAttachment.js Outdated
a-b-r-o-w-n
a-b-r-o-w-n reviewed Dec 13, 2018
View reviewed changes
Comment thread packages/component/src/Localization/sv-SE.js Outdated
Comment thread packages/component/src/Attachment/Assets/DownloadIcon.js Outdated
@corinagum
Copy link
Copy Markdown
Contributor Author

corinagum commented Dec 13, 2018

@cwhitten ping with PR fixes :)

cwhitten
cwhitten approved these changes Dec 13, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corinagum corinagum merged commit 5f2335c into microsoft:master Dec 13, 2018
@compulim compulim mentioned this pull request Dec 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n left review comments

@cwhitten cwhitten cwhitten approved these changes

@compulim compulim Awaiting requested review from compulim compulim is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corinagum @coveralls @cwhitten @a-b-r-o-w-n