Skip to content

Support new Cognitive Services Speech Services#1442

Merged
compulim merged 17 commits intomicrosoft:masterfrom
compulim:feat-speech-services
Dec 7, 2018
Merged

Support new Cognitive Services Speech Services#1442
compulim merged 17 commits intomicrosoft:masterfrom
compulim:feat-speech-services

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Dec 5, 2018

Will fix #1320, fix #1336, and fix #1422

Background

This PR will add support of Cognitive Services Speech Services.

Changelog

Added

  • Support Cognitive Services Speech Services, in PR #1442
    • Sample for Speech Services (both subscription key and authorization token flow)
    • Sample for using lexical result (text normalization)

@compulim compulim added 4.2 p0 Must Fix. Release-blocker labels Dec 5, 2018
@compulim compulim added this to the v4.2 milestone Dec 5, 2018
@compulim compulim changed the title DRAFT: Support new Cognitive Services Speech Services [DRAFT] Support new Cognitive Services Speech Services Dec 5, 2018
@compulim compulim force-pushed the feat-speech-services branch from 316a077 to 779c410 Compare December 6, 2018 00:37
Comment thread packages/bundle/.babelrc
Comment thread README.md
Comment thread packages/component/src/SendBox/DictationInterims.js
Comment thread packages/playground/src/App.js
Comment thread packages/playground/src/App.js
Comment thread serve.json
@compulim compulim self-assigned this Dec 6, 2018
@compulim compulim changed the title [DRAFT] Support new Cognitive Services Speech Services Support new Cognitive Services Speech Services Dec 6, 2018
Copy link
Copy Markdown
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick but otherwise looks fine!

Comment thread packages/bundle/src/createCognitiveServicesSpeechServicesPonyfillFactory.js Outdated
Copy link
Copy Markdown
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor clarifications and recommendations

@compulim compulim merged commit f483950 into microsoft:master Dec 7, 2018
@compulim compulim deleted the feat-speech-services branch December 7, 2018 16:58
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 550

  • 2 of 18 (11.11%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 44.881%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/SendBox/DictationInterims.js 0 1 0.0%
packages/bundle/src/createCognitiveServicesBingSpeechPonyfillFactory.js 0 7 0.0%
packages/bundle/src/createCognitiveServicesSpeechServicesPonyfillFactory.js 0 8 0.0%
Totals Coverage Status
Change from base Build 547: -0.1%
Covered Lines: 715
Relevant Lines: 1420

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p0 Must Fix. Release-blocker

Projects

None yet

5 participants