Fix activity without "from"#1405
Merged
compulim merged 2 commits intomicrosoft:masterfrom Nov 28, 2018
Merged
Conversation
Pull Request Test Coverage Report for Build 506
💛 - Coveralls |
corinagum
approved these changes
Nov 28, 2018
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Approved, pending nitpick CHANGELOG.md update
|
@compulim @corinagum is this supposed to work in the embedded WebChat in the Azure Portal? I was seeing the role being empty for activities sent from the bot, and I was wondering whether that is a bug or not? I had the preview checkbox enabled in the webchat channel configuration. |
|
Also using the following HTML taken from the Full bundle sample the <!DOCTYPE html>
<html>
<body>
<div id="webchat" role="main"></div>
<script src="https://cdn.botframework.com/botframework-webchat/latest/webchat.js"></script>
<script>
window.WebChat.renderWebChat({
directLine: window.WebChat.createDirectLine({ token: 'somesecret' }),
userID: 'myusername'
}, document.getElementById('webchat'));
</script>
</body>
</html> |
|
This works correctly in the Bot Emulator though. |
|
Tracking in #1886. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
activity.from.role"user"iffrom.idis user ID, otherwise,"bot"iffrom.idis anything otherwise,"channel", because eitherfromorfrom.idwas not defined (e.g. inConversationUpdateactivity)