Skip to content

Update sample verbiage & add new sample: migration from v3 to v4#1398

Merged
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:corinagum/migrationv3-v4
Nov 28, 2018
Merged

Update sample verbiage & add new sample: migration from v3 to v4#1398
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:corinagum/migrationv3-v4

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

Fixes #1237

  • Update sample verbiage
  • Add new sample: Migration from v3 to v4

@corinagum corinagum requested a review from compulim November 27, 2018 00:30
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 27, 2018

Pull Request Test Coverage Report for Build 511

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 46.598%

Files with Coverage Reduction New Missed Lines %
packages/core/src/sagas/incomingActivitySaga.js 2 81.08%
Totals Coverage Status
Change from base Build 483: 0.08%
Covered Lines: 713
Relevant Lines: 1370

💛 - Coveralls

Comment thread CHANGELOG.md Outdated
- `webpack`
- `[email protected]`
- `[email protected]`
- Fix [#1237](https://github.com/Microsoft/BotFramework-WebChat/issues/1237). Added new sample called `markdown`, by [@corinagum](https://github.com/corinagum) in PR [#1398](https://github.com/Microsoft/BotFramework-WebChat/pull/1398)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow... fix to 'migration'

Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect!

@corinagum corinagum merged commit 14c2dca into microsoft:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants