-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Output build should have correct version number burnt #2524
Copy link
Copy link
Closed
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.Required for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.customer-reportedRequired for internal Azure reporting. Do not delete.Required for internal Azure reporting. Do not delete.
Metadata
Metadata
Assignees
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.Required for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.customer-reportedRequired for internal Azure reporting. Do not delete.Required for internal Azure reporting. Do not delete.
Version
masterDescribe the bug
For the burnt version number, it appears to be
undefinedinstead of4.6.0.In PR #2182, we moved from vulnerable
babel-plugin-version-transformtobabel-plugin-transform-inline-environment-variables. The environment variable should be in lowercase,npm_package_version, instead ofNPM_PACKAGE_VERSION. Thus, the Babel plugin did not pick up and cannot burn it into the source file.To Reproduce
Steps to reproduce the behavior:
html/head/metaand see the burnt version of Web ChatExpected behavior
It should say
4.6.0or4.6.0-...or0.0.0-0(for development build).[Bug]