Skip to content

IE11: Number.isNaN is not available #1626

@compulim

Description

@compulim

In some of our code, we are using Number.isNaN. For example, https://github.com/Microsoft/BotFramework-WebChat/blob/master/packages/component/src/Localization/en-US.js#L12.

I think Number.isNaN is unnecessary in this case because the argument is always a number, so the result is same as global.isNaN. And second, IE11 does not support Number.isNaN.

Another change would be date.valueOf(). According to MDN, this is equivalent to date.getTime(). So I would recommend using date.getTime() for consistency.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions