Fallback to en-US for date time formatting (#2286)

compulim · corinagum · commit 00da40679931 · 2019-08-08T11:26:25.000-07:00
* Fallback to en-US

* Add test

* Update PR number

* Fix eslint
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -73,6 +73,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 -  Fix [#2245](https://github.com/microsoft/BotFramework-WebChat/issues/2245). Fix speech synthesis not working on Safari by priming the engine on the first microphone button click, by [@compulim](https://github.com/compulim) in PR [#2246](https://github.com/microsoft/BotFramework-WebChat/pull/2246)
 -  Fix [#1514](https://github.com/microsoft/BotFramework-WebChat/issues/1514). Added reference grammar ID when using Cognitive Services Speech Services, by [@compulim](https://github.com/compulim) in PR [#2246](https://github.com/microsoft/BotFramework-WebChat/pull/2246)
 -  Fix [#1515](https://github.com/microsoft/BotFramework-WebChat/issues/1515). Added dynamic phrases when using Cognitive Services Speech Services, by [@compulim](https://github.com/compulim) in PR [#2246](https://github.com/microsoft/BotFramework-WebChat/pull/2246)
+-  Fix [#2273](https://github.com/microsoft/BotFramework-WebChat/issues/2273). Add `ScreenReaderText` component, by [@corinagum](https://github.com/corinagum) in PR [#2278](https://github.com/microsoft/BotFramework-WebChat/pull/2278)
+-  Fix [#2231](https://github.com/microsoft/BotFramework-WebChat/issues/2231). Fallback to English (US) if date time formatting failed, by [@compulim](https://github.com/compulim) in PR [#2286](https://github.com/microsoft/BotFramework-WebChat/pull/2286)
 
 ### Added
 
diff --git a/__tests__/__image_snapshots__/chrome-docker/language-js-setting-language-to-empty-string-should-not-crash-1-snap.png b/__tests__/__image_snapshots__/chrome-docker/language-js-setting-language-to-empty-string-should-not-crash-1-snap.png
diff --git a/__tests__/language.js b/__tests__/language.js
@@ -0,0 +1,22 @@
+import { imageSnapshotOptions, timeouts } from './constants.json';
+
+import minNumActivitiesShown from './setup/conditions/minNumActivitiesShown';
+import uiConnected from './setup/conditions/uiConnected';
+
+// selenium-webdriver API doc:
+// https://seleniumhq.github.io/selenium/docs/api/javascript/module/selenium-webdriver/index_exports_WebDriver.html
+
+jest.setTimeout(timeouts.test);
+
+test('setting language to empty string should not crash', async () => {
+  const { driver, pageObjects } = await setupWebDriver();
+
+  await driver.wait(uiConnected(), timeouts.directLine);
+  await pageObjects.sendMessageViaSendBox('echo Hello', { waitForSend: true });
+
+  await driver.wait(minNumActivitiesShown(2), timeouts.directLine);
+
+  const base64PNG = await driver.takeScreenshot();
+
+  expect(base64PNG).toMatchImageSnapshot(imageSnapshotOptions);
+});
diff --git a/packages/component/src/Localization/getLocaleString.js b/packages/component/src/Localization/getLocaleString.js
@@ -1,3 +1,5 @@
+/* eslint no-empty: ["error", { "allowEmptyCatch": true }] */
+
 export default function getLocaleString(value, language) {
   const date = new Date(value);
   const options = {
@@ -8,8 +10,17 @@ export default function getLocaleString(value, language) {
     month: 'long'
   };
 
-  if (window.Intl) {
-    return !!date && new Intl.DateTimeFormat(language, options).format(date);
-  }
-  return date.toLocaleDateString(language, options);
+  try {
+    if (window.Intl) {
+      return !!date && new Intl.DateTimeFormat(language, options).format(date);
+    }
+  } catch (err) {}
+
+  try {
+    return date.toLocaleDateString(language, options);
+  } catch (err) {}
+
+  // Fallback to en-US if failed, for example, invalid language code would throw exception
+
+  return date.toLocaleDateString('en-US', options);
 }
