This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Increased wait time to 40seconds to spin ngrok process#2212
Merged
Conversation
added 2 commits
December 16, 2020 15:42
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
srinaath
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
tonyanziano
approved these changes
Dec 17, 2020
| this.ngrokProcess.stdout.on('data', onNgrokData); | ||
| process.on('exit', this.kill); | ||
| process.on('exit', () => { | ||
| this.kill(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
thiscontext on process exit. Currently. on process exit emulator does not cleanup ngrok process that was spawned@garypretty