This repository was archived by the owner on Jan 5, 2026. It is now read-only.
fix: Webchat socket instantiation delay#2179
Merged
Conversation
added 3 commits
August 20, 2020 20:10
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…nection starts Signed-off-by: Srinaath Ravichandran <[email protected]>
added 2 commits
August 21, 2020 10:27
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
cwhitten
approved these changes
Aug 21, 2020
tonyanziano
pushed a commit
that referenced
this pull request
Aug 31, 2020
* Webchat Upgrade and Version number change Signed-off-by: Srinaath Ravichandran <[email protected]> * Handle change to middleware (#2177) * Handle change to middleware * Updated babel preset env Signed-off-by: Srinaath Ravichandran <[email protected]> * Reverted change to babel Signed-off-by: Srinaath Ravichandran <[email protected]> Locks updated to pre webchat change Signed-off-by: Srinaath Ravichandran <[email protected]> Post wechat check Signed-off-by: Srinaath Ravichandran <[email protected]> Prevent hoisting bf-chatdown Signed-off-by: Srinaath Ravichandran <[email protected]> * Updated babel preset env Signed-off-by: Srinaath Ravichandran <[email protected]> * fix: Webchat socket instantiation delay (#2179) * Updated websocket server code to backup messages if it is not connected * Refactored more occurances of socket send * Renaming variables * Added unit test to make sure backedup messages are cleared before connection starts * Lint fix * Updated release date Signed-off-by: Srinaath Ravichandran <[email protected]> * All tests working Signed-off-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Srinaath Ravichandran <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles the case of webchat's delay in connecting to the socket created for a conversation. As a temporary fix activities are queued and once connected we clear the queue first before sending new messages