This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Fixed issue with websocket connections being closed when deep linking …#2146
Merged
tonyanziano merged 1 commit intov4.9.0from May 14, 2020
Merged
Fixed issue with websocket connections being closed when deep linking …#2146tonyanziano merged 1 commit intov4.9.0from
tonyanziano merged 1 commit intov4.9.0from
Conversation
… into a conversation.
df01ef8 to
ebb27aa
Compare
srinaath
approved these changes
May 14, 2020
Contributor
|
Nice catch!! |
tonyanziano
added a commit
that referenced
this pull request
May 14, 2020
* Prepped v4.9.0 release * Bump webchat to 4.9.0 Signed-off-by: Srinaath Ravichandran <[email protected]> * Changelog updated Signed-off-by: Srinaath Ravichandran <[email protected]> * Changed readme Signed-off-by: Srinaath Ravichandran <[email protected]> * Allow micrphone usage from electron Signed-off-by: Srinaath Ravichandran <[email protected]> * Updates to lock files Signed-off-by: Srinaath Ravichandran <[email protected]> * Removed dependancies to botbuilder myget for regular npm js libs Signed-off-by: Srinaath Ravichandran <[email protected]> * Revert lock back to master Signed-off-by: Srinaath Ravichandran <[email protected]> * PR number update Signed-off-by: Srinaath Ravichandran <[email protected]> * Fixed issue with websocket connections being closed when deep linking into a conversation. (#2146) Co-authored-by: Srinaath Ravichandran <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…into a conversation.
===
Fixes #2144
===
This issue was a Windows-only (possibly Linux as well) bug that was happening due to the following:
ready-to-showevent is fired, and so before the WebSocket server is initializedready-to-showbrowser window event is then fired and the web socket server is re-initialized which then callscleanup(), closing the previously connected websocket for the running conversation===
This PR fixes that issue by changing the websocket server logic to only initialize the server once and return the port, instead of re-initializing if already running.
This means that the second call to
WebSocketServer.init()in step 6 above results in a no-op and instead just returns the websocket server port.===
This does not occur on Mac because the protocol URLs are parsed and executed after the initial setup of the websocket server inside of the
ready-to-showbrowser window event handler