Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Enabled communication with remote Direct Line Speech bots#2079

Merged
tonyanziano merged 5 commits intomasterfrom
toanzian/dl-speech
Feb 20, 2020
Merged

Enabled communication with remote Direct Line Speech bots#2079
tonyanziano merged 5 commits intomasterfrom
toanzian/dl-speech

Conversation

@tonyanziano
Copy link
Copy Markdown
Contributor

@tonyanziano tonyanziano commented Feb 13, 2020

Fixes #2040

===

This PR adds the ability to connect to a remote Direct Line Speech bot by entering a speech key and speech region when connecting to a bot.

Example:

region: westus
key: some-speech-key-guid

image

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 13, 2020

Coverage Status

Coverage increased (+0.1%) to 68.163% when pulling 252a43a on toanzian/dl-speech into 8ca1397 on master.

@tonyanziano
Copy link
Copy Markdown
Contributor Author

tonyanziano commented Feb 13, 2020

Linting is very unhappy due to a patch bump from [email protected] to 2.20.1 as a side effect of regenerating the package-lock. This causes all of our import statements to fail linting resulting in a 400+ file change to satisfy the updated linter.

I'm going to make a separate PR that locks the eslint-plugin-import package to 2.20.0 so that we do not have to deal with this massive linting delta. (#2081 )

Comment thread packages/app/shared/tsconfig.json
Comment thread packages/app/client/src/state/utils/throwErrorFromResponse.ts Outdated
Comment thread packages/app/client/src/state/sagas/chatSagas.ts Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify WebChat implementation to support connecting to a Direct Line Speech bot remotely

3 participants