Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Srravich/bugfix/1929 attachment#2068

Merged
tonyanziano merged 4 commits intomasterfrom
srravich/bugfix/1929-attachment
Jan 30, 2020
Merged

Srravich/bugfix/1929 attachment#2068
tonyanziano merged 4 commits intomasterfrom
srravich/bugfix/1929-attachment

Conversation

@srinaath
Copy link
Copy Markdown
Contributor

@srinaath srinaath commented Jan 29, 2020

Attachment bubble colors set

Before
before-filename-hidden

After

High Contrast Theme
Screen Shot 2020-01-29 at 12 50 09 PM

Dark Theme
Screen Shot 2020-01-29 at 12 50 18 PM

Light Theme
Screen Shot 2020-01-29 at 12 50 25 PM

Srinaath Ravichandran added 2 commits January 29, 2020 11:51
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 29, 2020

Coverage Status

Coverage increased (+0.01%) to 69.589% when pulling e9626ce on srravich/bugfix/1929-attachment into b024544 on master.

Signed-off-by: Srinaath Ravichandran <[email protected]>
corinagum
corinagum previously approved these changes Jan 30, 2020
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Srinaath Ravichandran <[email protected]>
@tdurnford
Copy link
Copy Markdown

It looks like microsoft/BotFramework-WebChat#2868 is removing the UploadAttachment component, so you may want to wait to make these changes until the Emulator bumps the Web Chat dependency to 4.8.0

@srinaath
Copy link
Copy Markdown
Contributor Author

@tdurnford
Tracking this change in this ticket #2071. But, I think we still need to get this PR in until we bump Webchat dependency for Emulator. Currently the labels on Upload and Download Attachment are completely hidden. Once William's PR is merged I can change to target the FileAttachment class instead of DownloadAttachment. What do you think?

@tonyanziano tonyanziano merged commit 272b3c2 into master Jan 30, 2020
@tonyanziano tonyanziano deleted the srravich/bugfix/1929-attachment branch January 30, 2020 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants