Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Fixed an issue with adding a QnA KB.#2066

Merged
tonyanziano merged 2 commits intomasterfrom
toanzian/qnamaker
Jan 29, 2020
Merged

Fixed an issue with adding a QnA KB.#2066
tonyanziano merged 2 commits intomasterfrom
toanzian/qnamaker

Conversation

@tonyanziano
Copy link
Copy Markdown
Contributor

Fixes #1875

===

  • After signing into Azure, trying to add a QnA maker KB would cause the in-memory QnA maker service to be initialized with a blank hostname, which was causing msbot to throw and crash the app

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 29, 2020

Coverage Status

Coverage increased (+0.002%) to 69.576% when pulling c20dc22 on toanzian/qnamaker into e200c7f on master.

srinaath
srinaath previously approved these changes Jan 29, 2020
Comment thread packages/app/client/src/state/sagas/servicesExplorerSagas.ts Outdated
@tonyanziano tonyanziano merged commit 1c5e370 into master Jan 29, 2020
@tonyanziano tonyanziano deleted the toanzian/qnamaker branch January 29, 2020 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connecting to a QnA maker knowledge base button throws an error

3 participants