This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Conversation
added 3 commits
January 24, 2020 12:45
Signed-off-by: Srinaath Ravichandran <[email protected]> Stable commit to be refactored Signed-off-by: Srinaath Ravichandran <[email protected]> safe ngrok status viewer display Signed-off-by: Srinaath Ravichandran <[email protected]> Last ping interval set Signed-off-by: Srinaath Ravichandran <[email protected]> Ngrok tab updated Signed-off-by: Srinaath Ravichandran <[email protected]> Tunnel classes updated Signed-off-by: Srinaath Ravichandran <[email protected]> Stable ngrok tests Signed-off-by: Srinaath Ravichandran <[email protected]> Fetch with timeout updated Signed-off-by: Srinaath Ravichandran <[email protected]> Reducer specs updated Signed-off-by: Srinaath Ravichandran <[email protected]> Ngrok tunnel action test updated Signed-off-by: Srinaath Ravichandran <[email protected]> All tests on client and main pass Signed-off-by: Srinaath Ravichandran <[email protected]> Removed ngrok notification icon Signed-off-by: Srinaath Ravichandran <[email protected]> ngrok tab test Signed-off-by: Srinaath Ravichandran <[email protected]> Code review cleanup Signed-off-by: Srinaath Ravichandran <[email protected]> Safe commit for tracking notifications Signed-off-by: Srinaath Ravichandran <[email protected]> Lock updated Signed-off-by: Srinaath Ravichandran <[email protected]> Saga update Signed-off-by: Srinaath Ravichandran <[email protected]> Clearning notifications when status shifts from error to Active Signed-off-by: Srinaath Ravichandran <[email protected]> Tests and copy working Signed-off-by: Srinaath Ravichandran <[email protected]> Moved check for reporting upto ngrok Signed-off-by: Srinaath Ravichandran <[email protected]> Using status instead status code Signed-off-by: Srinaath Ravichandran <[email protected]> TEst build Signed-off-by: Srinaath Ravichandran <[email protected]> Package json updated Signed-off-by: Srinaath Ravichandran <[email protected]> Tests completed Signed-off-by: Srinaath Ravichandran <[email protected]> Reverted to electron rebuilder to support windows Signed-off-by: Srinaath Ravichandran <[email protected]> Console log removed Signed-off-by: Srinaath Ravichandran <[email protected]> handling timeouts Signed-off-by: Srinaath Ravichandran <[email protected]> All tests passing for sagas Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
srinaath
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
tdurnford and
tonyanziano
srinaath
changed the title
srinaath
changed the title
tonyanziano
suggested changes
Jan 28, 2020
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
Left a few minor comments.
added 3 commits
January 28, 2020 07:50
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Added tests fro ngrokCommands Removed comments fixed typos Added high contrast specific var Signed-off-by: Srinaath Ravichandran <[email protected]>
tonyanziano
previously approved these changes
Jan 28, 2020
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
One small comment, but looks good 👍
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
This was referenced Jan 29, 2020
srinaath
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wraps up all the UX interactions for Ngrok Status Viewer.