This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Moved shared store code to app/shared.#2060
Merged
tonyanziano merged 3 commits intomasterfrom Jan 30, 2020
Merged
Conversation
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
srinaath and
tdurnford
as code owners
Contributor
Author
|
I didn't really add any new code, I just deleted a bunch of duplicate tested code and I believe that's why the coverage dropped: Before: 2633 of 4488 branches covered (58.67%) After: 2428 of 4267 branches covered (56.9%) |
tonyanziano
force-pushed
the
toanzian/state
branch
from
78c9403 to
a3feeba
Compare
srinaath
previously approved these changes
Jan 30, 2020
Contributor
|
This PR is awesome @tonyanziano . So much redundancy removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2038
===
Basically moved all reducer and action code to
packages/app/shared/state.So 99% of this PR is changing imports from:
to
import { bot, closeBot } from '@bfemulator/app-shared';350 files... whoops 😅