Moved qnamaker hostname to constants file.

tonyanziano · tonyanziano · commit c20dc228ed88 · 2020-01-29T10:04:53.000-08:00
diff --git a/packages/app/client/src/constants.ts b/packages/app/client/src/constants.ts
@@ -56,3 +56,6 @@ export const DOCUMENT_ID_APP_SETTINGS = 'app:settings';
 export const DOCUMENT_ID_BOT_SETTINGS = 'bot:settings';
 export const DOCUMENT_ID_WELCOME_PAGE = 'welcome-page';
 export const DOCUMENT_ID_MARKDOWN_PAGE = 'markdown-page';
+
+/* a QnA maker service needs to be initialized with a valid hostname or msbot will throw */
+export const QnAMakerSampleHostname = 'https://myqna.azurewebsites.net';
diff --git a/packages/app/client/src/state/sagas/servicesExplorerSagas.ts b/packages/app/client/src/state/sagas/servicesExplorerSagas.ts
@@ -64,6 +64,7 @@ import {
 import { sortExplorerContents } from '../actions/explorerActions';
 import { SortCriteria } from '../reducers/explorer';
 import { RootState } from '../store';
+import { QnAMakerSampleHostname } from '../../constants';
 
 import { AzureAuthSaga } from './azureAuthSaga';
 
@@ -166,8 +167,7 @@ export class ServicesExplorerSagas {
     if (result === 1) {
       action.payload.connectedService = BotConfigurationBase.serviceFromJSON({
         type,
-        hostname:
-          'https://myqna.azurewebsites.net' /* a QnA maker service needs to be initialized with a valid hostname or msbot will throw */,
+        hostname: QnAMakerSampleHostname,
       } as any);
       result = yield* ServicesExplorerSagas.launchConnectedServiceEditor(action);
     }
diff --git a/packages/app/client/src/ui/shell/explorer/servicesExplorer/connectedServiceEditor/connectedServiceEditor.tsx b/packages/app/client/src/ui/shell/explorer/servicesExplorer/connectedServiceEditor/connectedServiceEditor.tsx
@@ -39,6 +39,7 @@ import * as React from 'react';
 import { ChangeEvent, Component, ReactNode } from 'react';
 
 import { serviceTypeLabels } from '../../../../../utils/serviceTypeLables';
+import { QnAMakerSampleHostname } from '../../../../../constants';
 
 import * as styles from './connectedServiceEditor.scss';
 import { KvPair } from './kvPair';
@@ -106,8 +107,7 @@ export class ConnectedServiceEditor extends Component<ConnectedServiceEditorProp
     };
     // if qnamaker, initialize with sample hostname so that botframework-config doesn't throw
     if (props.serviceType === ServiceTypes.QnA) {
-      (connectedService as IQnAService).hostname =
-        (connectedService as IQnAService).hostname || 'https://myqna.azurewebsites.net';
+      (connectedService as IQnAService).hostname = (connectedService as IQnAService).hostname || QnAMakerSampleHostname;
     }
     this.state = {
       connectedServiceCopy: BotConfigurationBase.serviceFromJSON(connectedService),
