Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Commit b1a777a

Browse files
committed
Fixed content of signed in view of Cosmos DB service dialog.
1 parent e164c01 commit b1a777a

4 files changed

Lines changed: 42 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88
## Added
99
- [client] Added a log panel entry at the start of a conversation that displays the bot endpoint in PR [2149](https://github.com/microsoft/BotFramework-Emulator/pull/2149)
1010

11+
## Fixed
12+
- [client] Added missing content to signed in view of Cosmos DB service dialog and fixed product page link in PR [2150](https://github.com/microsoft/BotFramework-Emulator/pull/2150)
13+
1114
## v4.9.0 - 2020 - 05 - 11
1215
## Added
1316
- [main] Exposed `id` field on response object returned from `/v3/conversations` endpoint in PR [2129](https://github.com/microsoft/BotFramework-Emulator/pull/2129)

packages/app/client/src/state/sagas/servicesExplorerSagas.spec.ts

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ describe('The ServiceExplorerSagas', () => {
467467
);
468468
});
469469

470-
it(' should open a QnA maker external link', () => {
470+
it('should open a QnA maker external link', () => {
471471
const payload = {
472472
azureAuthWorkflowComponents: {
473473
loginFailedDialog: AzureLoginFailedDialogContainer,
@@ -494,6 +494,34 @@ describe('The ServiceExplorerSagas', () => {
494494
)
495495
);
496496
});
497+
498+
it('should open a Cosmos DB external link', () => {
499+
const payload = {
500+
azureAuthWorkflowComponents: {
501+
loginFailedDialog: AzureLoginFailedDialogContainer,
502+
loginSuccessDialog: AzureLoginSuccessDialogContainer,
503+
promptDialog: ConnectServicePromptDialogContainer,
504+
},
505+
getStartedDialog: GetStartedWithCSDialogContainer,
506+
editorComponent: ConnectedServiceEditorContainer,
507+
pickerComponent: ConnectedServicePickerContainer,
508+
serviceType: ServiceTypes.CosmosDB,
509+
};
510+
511+
action = launchExternalLink(payload as any);
512+
sagaIt = ServicesExplorerSagas.launchExternalLink;
513+
514+
const it = sagaIt(action);
515+
const result = it.next().value;
516+
517+
expect(result).toEqual(
518+
call(
519+
[commandService, commandService.remoteCall],
520+
SharedConstants.Commands.Electron.OpenExternal,
521+
'https://azure.microsoft.com/services/cosmos-db/'
522+
)
523+
);
524+
});
497525
});
498526

499527
describe(' openAddConnectedServiceContextMenu', () => {

packages/app/client/src/state/sagas/servicesExplorerSagas.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,14 @@ export class ServicesExplorerSagas {
267267
);
268268
break;
269269

270+
case ServiceTypes.CosmosDB:
271+
yield call(
272+
[ServicesExplorerSagas.commandService, ServicesExplorerSagas.commandService.remoteCall],
273+
SharedConstants.Commands.Electron.OpenExternal,
274+
'https://azure.microsoft.com/services/cosmos-db/'
275+
);
276+
break;
277+
270278
default:
271279
return;
272280
}

packages/app/client/src/ui/dialogs/getStartedWithCSDialog/getStartedWithCSDialog.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,15 @@ const titleMap = {
5353
[ServiceTypes.Dispatch]: 'Connect to a Dispatch model',
5454
[ServiceTypes.QnA]: 'Create a QnA Maker knowledge base',
5555
[ServiceTypes.BlobStorage]: 'Create a Blob Storage Container',
56+
[ServiceTypes.CosmosDB]: 'Connect to a Cosmos DB account',
5657
};
5758

5859
const buttonTextMap = {
5960
[ServiceTypes.Luis]: 'LUIS',
6061
[ServiceTypes.Dispatch]: 'Dispatch',
6162
[ServiceTypes.QnA]: 'QnA Maker',
6263
[ServiceTypes.BlobStorage]: 'Blob Storage',
64+
[ServiceTypes.CosmosDB]: 'Cosmos DB',
6365
};
6466

6567
export class GetStartedWithCSDialog extends Component<GetStartedWithCSDialogProps, {}> {

0 commit comments

Comments
 (0)