fix for AspNetCore AddApplicationInsightsSettings() and MissingMethodException#1703
Merged
TimothyMothra merged 2 commits intodevelopfrom Feb 21, 2020
Merged
Conversation
| /// <param name="connectionString">Sets connection string.</param> | ||
| /// <returns>The <see cref="IConfigurationBuilder"/>.</returns> | ||
| public static IConfigurationBuilder AddApplicationInsightsSettings(this IConfigurationBuilder configurationSourceRoot, bool? developerMode = null, string endpointAddress = null, string instrumentationKey = null) | ||
| => configurationSourceRoot.AddApplicationInsightsSettings(developerMode, endpointAddress, instrumentationKey); |
Member
There was a problem hiding this comment.
This method call does not seem to use connectionString parameter or assign it to null - can you take a look?
Author
There was a problem hiding this comment.
wow, so I was blindly trusting unit tests to catch something like this.
what actually happened was that it is an infinite loop, which crashes the test assembly and no errors get reported.
learning lots of things today
Dmitry-Matveev
approved these changes
Feb 21, 2020
TimothyMothra
pushed a commit
that referenced
this pull request
Feb 21, 2020
…Exception (#1703) * fix for AspNetCore AddApplicationInsightsSettings() and MissingMethodException * fix
TimothyMothra
pushed a commit
that referenced
this pull request
Feb 21, 2020
…Exception (#1703) * fix for AspNetCore AddApplicationInsightsSettings() and MissingMethodException * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #1702.
Changes
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build