Skip to content

Conversation

@dpgeorge
Copy link
Member

Changes here are split out from #8451:

  • set FullDuplexMode struct entry on F4 MCUs
  • allow I2S.deinit to be called multiple times
  • fixed 16-bit stereo frame mapping
  • add test to measure data rate (works on stm32, rp2)
  • clarify what rate is in docs

@dpgeorge
Copy link
Member Author

@miketeachman if you could review this, that'd be great!

@miketeachman
Copy link
Contributor

@dpgeorge
It looks good to me. I code reviewed and cherry-picked 3 commits (full-duplex, deinit, and 16-bit stereo) and tested them on the hardware. No issues. I code reviewed the test but didn't try running it.

In particular, it is called by the constructor if the instance already
exists.  So if the previous instance was deinit'd then it will be deinit'd
a second time.

Signed-off-by: Damien George <[email protected]>
@dpgeorge dpgeorge force-pushed the stm32-i2s-fixes-and-rate-test branch from 556e5f9 to 5e685a9 Compare March 29, 2022 00:45
@dpgeorge dpgeorge merged commit 5e685a9 into micropython:master Mar 29, 2022
@dpgeorge dpgeorge deleted the stm32-i2s-fixes-and-rate-test branch March 29, 2022 01:02
@dpgeorge
Copy link
Member Author

Thanks for reviewing and testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants