py: Support passing in an OrderedDict to type() as the locals. #6176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewleech
reviewed
Jun 22, 2020
| #define mp_obj_is_int(o) (mp_obj_is_small_int(o) || mp_obj_is_type(o, &mp_type_int)) | ||
| #define mp_obj_is_str(o) (mp_obj_is_qstr(o) || mp_obj_is_type(o, &mp_type_str)) | ||
| #define mp_obj_is_str_or_bytes(o) (mp_obj_is_qstr(o) || (mp_obj_is_obj(o) && ((mp_obj_base_t *)MP_OBJ_TO_PTR(o))->type->binary_op == mp_obj_str_binary_op)) | ||
| #define mp_obj_is_dict_or_ordereddict(o) (mp_obj_is_obj(o) && ((mp_obj_base_t *)MP_OBJ_TO_PTR(o))->type->make_new == mp_obj_dict_make_new) |
Contributor
There was a problem hiding this comment.
This is a nice optimisation saving the extra conditional check!
Contributor
|
Thanks for separating / re-implementing this so cleanly, looks great to me. |
And use it in py/objdict.c instead of mp_obj_is_dict_type. Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
An OrderedDict can now be used for the locals when creating a type explicitly via type(name, bases, locals). Signed-off-by: Damien George <[email protected]>
dpgeorge
force-pushed
the
py-objtype-ordereddict
branch
from
32d7fe7 to
457fdf6
Compare
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Mar 21, 2022
Vectorio color index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off frm #6130, this PR adds support for passing in an
OrderedDictfor the locals of a new class, usingtype(name, bases, locals), wherelocalscan now be anOrderedDict.The changes here introduce a new helper
mp_obj_is_dict_or_ordereddict()and update existing code to use it (which decreases code size inextmod/moductypes.c). The actual feature of using OrderedDict as class locals costs 0 bytes.