py/obj.h: Clarify comments about mp_map_t is_fixed and is_ordered. #6129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Relates to #5664 @andrewleech FYI |
Contributor
|
These comments make a lot more sense, thanks! |
Long ago, prior to 0ef01d0, fixed and ordered maps were the same setting with the "table_is_fixed_array" member of mp_map_t. But these settings are actually independent, and it is possible to have is_fixed=1, is_ordered=0 (although this can currently only be done by tools/cc1). So update the comments to reflect this.
dpgeorge
force-pushed
the
py-obj-clarify-map-comments
branch
from
388f921 to
f3062b5
Compare
jonathanhogg
added a commit
to jonathanhogg/micropython
that referenced
this pull request
Sep 14, 2021
Rework the ADC implementation to use the micropython#4213 API (mostly) adding support for calibrated voltage readings and the ADC2 block. Resolves micropython#6129. Part-resolves micropython#3943.
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Mar 14, 2022
Espressif: Fix i2c pullup detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long ago, prior to 0ef01d0, fixed and ordered maps were the same setting with the "table_is_fixed_array" member of mp_map_t. But these settings are actually independent, and it is possible to have is_fixed=1, is_ordered=0 (although this can currently only be done by tools/cc1). So update the comments to reflect this.