extmod/uasyncio: fix wait_for completely #5931
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fully fix wait_for by using uasyncio.shield() to correct the cancellation order.
for catching exceptions and cancellation order
This was referenced Nov 30, 2020
Member
|
Sorry for neglecting this. The approach here uses See #6667 for an alternative approach which does not have these overheads. |
Member
|
Thanks again for contributing this. It has been fixed differently in b505971 |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Feb 18, 2022
This allows board code to override the default pull up reset state. It is useful for pins that are already externally connected, pulled or otherwise used by the board. Fixes micropython#5931
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all known bugs with wait_for by using the shield() implementation added by #5928
However, a small change in core.py was needed to suppress the exception_handler from being called when an exception in the awaited task is being thrown. This happens because shield() detaches wait_for and the awaited task from each other and reverses the cancellation order to match CPython's mechanism.
This change will have to be implemented in _uasyncio Task too but I have not checked that.
This also fixes the issue that the awaited task could just ignore the cancellation.
This PR deprecates #5918 which only partially fixes wait_for.