extmod/uasyncio: fix wait_for cancellation #5918
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix errors when wait_for gets cancelled.
for wait_for being cancelled.
for wait_for being cancelled
Contributor
Author
|
Added the testcase too. Without the PR changes the test will result in an error "local variable referenced before assignment" |
Member
|
Superseded and fixed by b505971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors when wait_for gets cancelled.
If wait_for() itself gets cancelled, wait_for currently doesn't know if itself got cancelled or if the killer task cancelled the awaited task aw.
Fixes parts of #5797