-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
stm32/boards: Add WeAct_H743VI board support. #17766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code size report: |
|
Just letting you know that I've already raised #12540 that adds the same board definition. It'd be great if you could take a look and see if there is any benefit from combining our efforts! |
|
@mattytrentini |
15da3f2 to
ae646d4
Compare
Add OctoSPI definition, ROMFS feature. Combined efforts from micropython#12540, micropython#17766: * Change peripheral ports, pin definitions. * Change board definition name: WeAct_H723VG-> WEACT_STM32H723. * Add deploy.md. Signed-off-by: Yuuki NAGAO <[email protected]>
Add OctoSPI definition, ROMFS feature. Combined efforts from micropython#12540, micropython#17766: * Change peripheral ports, pin definitions. * Change board definition name: WeAct_H723VG-> WEACT_STM32H723. * Add deploy.md. Signed-off-by: Yuuki NAGAO <[email protected]>
Add OctoSPI definition, ROMFS feature. Combined efforts from micropython#12540, micropython#17766: * Change peripheral ports, pin definitions. * Change board definition name: WeAct_H723VG-> WEACT_STM32H723. * Add deploy.md. Signed-off-by: Yuuki NAGAO <[email protected]>
Add OctoSPI definition, ROMFS feature. Combined efforts from micropython#12540, micropython#17766: * Change peripheral ports, pin definitions. * Change board definition name: WeAct_H723VG-> WEACT_STM32H723. * Add deploy.md. Signed-off-by: Yuuki NAGAO <[email protected]>
dpgeorge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, and thanks for incorporating part of #12540.
Regarding the board name: the vendor is "WeAct Studio", and the board is "Mini STM32H743". So I suggest naming the board folder as:
WEACTSTUDIO_MINI_STM32H743
That matches the existing rp2 boards by WeAct Studio (namely WEACTSTUDIO and WEACTSTUDIO_RP2350B_CORE). And is also consistent with the naming that Zephyr chose for this board: https://docs.zephyrproject.org/latest/boards/weact/mini_stm32h743/doc/index.html
Fix review comment on micropython#17766. Signed-off-by: Yuuki NAGAO <[email protected]>
|
Thank you for your review. |
This change adds WeAct Studio Mini STM32H743 board support to the STM32 port. Some of the work from PR micropython#12540 is combined here. WeAct Studio Mini STM32H43 board: https://github.com/WeActStudio/MiniSTM32H7xx This board uses STM32H743VI: https://www.st.com/en/microcontrollers-microprocessors/stm32h743vi.html Signed-off-by: Yuuki NAGAO <[email protected]>
dpgeorge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating. It looks good now.
1e8cb4f to
9b73e34
Compare
Add OctoSPI definition, ROMFS feature. Combined efforts from micropython#12540, micropython#17766: * Change peripheral ports, pin definitions. * Change board definition name: WeAct_H723VG-> WEACT_STM32H723. * Add deploy.md. Signed-off-by: Yuuki NAGAO <[email protected]>
Fix review comment on micropython#17766. Signed-off-by: Yuuki NAGAO <[email protected]>
Summary
This change adds WeAct STM32H743 Core Board support to the STM32 port.
WeAct STM32H743 Core Board:
https://github.com/WeActStudio/MiniSTM32H7xx
This board uses STM32H743VI:
https://www.st.com/en/microcontrollers-microprocessors/stm32h743vi.html
Testing
Tested:
Trade-offs and Alternatives
There is no negative impact because this change contains only adding board definition.